Heroic Trial Does Not Show In Groupie Raid Lockout

[KicaMwMw]

When you do Trial of the Crusader on Heroic, your character's name is not listed in the Groupie lockout list.

For example, character A does Trial of the Crusader on normal. When you check Groupie, under Trial of the Crusader, character A's name is listed. Now character B does Trial of the Crusader on heroic. When you check Groupie, under Trial of the Crusader, character A's name is listed but character B's name is not.

[Gogo1951]

Hey @KicaMwMw ,

I don't play any more, but I think @TannerShmoog wanted to do a few updates.

I stopped playing back in April or so. It's not clear to me that very many people ever used this / still use it.

Just to set expectations, I don't think it's highly likely any updates are coming to this add-on.

Sorry mate.

[kathelas]

As one of the people using this literally just for the raid lockout list across multiple characters, first of all thank you very much for your work. Any update fixing this issue would be awesome although I can totally understand if it's not happening if you don't play anymore. If you have an idea what could cause this issue or point me in the right direction to maybe fix it myself that would also be appreciated.
Thanks again for making this it has the best cross character lockout list out of all the different addons I tried.

[TannerShmoog]

Hi kathelas, could you run the following function for me on a character you're currently locked on and paste me the output that would help. The most likely issue is that the names given in the return of GetSavedInstanceInfo() are not listed anywhere and are for some reason different than localized names in every other location (i.e. The Sunwell instead of Sunwell Plateau is one we encountered in TBC). Unfortunately neither of us play anymore, so I can't run the command myself.

function() for i = 1, GetNumSavedInstances() do local ... = GetSavedInstanceInfo(i) print(...) end end

[kathelas]

Thank you very much for the quick response.
Sorry this took a while, cause I wasn't home this week and have no lockouts for TOGC right now and had to ask someone in guild to do this for me. The function you gave me also didn't work (maybe I'm just too stupid), so I just manually called GetSavedInstanceInfo and printed all the output (looking at this: https://wowwiki-archive.fandom.com/wiki/API_GetSavedInstanceInfo)

25man heroic:

10man heroic:

If you would like anything else, like maybe the info for a non heroic I would have to look for someone who didn't do heroic this week.
Thank you for your help.

[TannerShmoog]

This should be all I need, I'll have a look at it tonight. Likely the issue is that we internally recognize heroic trial as "trial of the grand crusader". There's a method built for dealing with this just need to expand the data

[TannerShmoog]

Ive pushed a potential fix here 2e098cb I dont have a sub though, so before I make it an official build, do you mind installing the addon from the main branch of this repo manually and checking that the lockout now shows? Nothing else should have broken. Just log in to a character that has a lockout once you've done it this week and wait 3-5 seconds after login. If it looks good Ill push the build to curse

[kathelas]

Yep, got it. Thank you.
My earliest TOGC 25m raid this week will be on Thursday, might be doing some 10m before. Will let you know ASAP.

[kathelas]

Looks like it's working now.
Thank you!

[Gogo1951]

Weird to call it "Heroic Trial of the Grand Crusader" isn't it?

https://www.wowhead.com/wotlk/zone=4722/trial-of-the-crusader

It's Trial of the Crusader, or "Heroic" Mode is "Trial of the Grand Crusader" -- but adding "Heroic Trial of the Grand Crusader" feels redundant.

[TannerShmoog]

I can fix that but it would just be a hard coded display only exception, fixing it properly requires a pretty big refactor as its coming from the data sheet where it is reffered to for disambiguation reasons internally like, everywhere in the entire addon

[kathelas]

A similar bug I also noticed is, it doesn't show AQ40 in the lockout list. This is very low priority ofc, just putting it here for the sake of completionism.
My raid lockouts:

Groupie lockout list:

AQ40 InstanceInfo: