Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summarizer sample: Format markdown output #1283

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sebastianbenz
Copy link
Collaborator

Also call the API in the same way as the official sample.

@sebastianbenz sebastianbenz changed the title Format markdown output Summarizer sample: Format markdown output Sep 13, 2024
Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me! Love the use of dompurify.

@@ -1,3 +1,6 @@
import DOMPurify from '../node_modules/dompurify/dist/purify.es.mjs';
import { marked } from '../node_modules/marked/marked.min';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite unusual to import from a relative path like this. Could you look at what setup would be needed so you can just import from "marked"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants