Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix chrome connection in node 17, use 127.0.0.1 explicitly #253

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix chrome connection in node 17, use 127.0.0.1 explicitly #253

merged 1 commit into from
Nov 2, 2021

Conversation

connorjclark
Copy link
Collaborator

fixes #251

paulirish
paulirish approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt test it, but.. it sounds legit.

@brendankenny
Copy link
Member

it's definitely backwards compatible?

@connorjclark
Copy link
Collaborator Author

I tried it on node 16 and LH and it worked groovy

@connorjclark connorjclark mentioned this pull request Nov 1, 2021
Merged
@connorjclark connorjclark merged commit 3e65a66 into master Nov 2, 2021
@connorjclark connorjclark deleted the node17-fix branch November 2, 2021 17:45
@rpl rpl mentioned this pull request Nov 26, 2021
Closed
@akaltar akaltar mentioned this pull request Nov 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ECONNREFUSED with Node 17
3 participants
@connorjclark @brendankenny @paulirish