Move implicit directory repair from list to delete operations #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
medb
changed the title
medb
approved these changes
Apr 2, 2019
|
Great contribution, thank you! |
medb
added a commit
that referenced
this pull request
May 14, 2019
…Status` methods Note: this is essentially the same change as in [] that triggered omg/12873 in the past, but it has feature flag that turns off it by default and tests that assert number of GCS requests when parallelism is enabled. In the worst case `getFileStatus` method can make up to 3 sequential requests to GCS to get implicit directory status. After moving implicit directory repair from list to delete/rename operations this worst case could be more frequent than before, because there higher chance to encounter implicit non-repaired directory: #156 This CL adds an option to execute these GCS requests in parallel which could reduce latency by up to 3 times. Change on 2019/05/13 by idv <idv@google.com> ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=248044068
medb
added a commit
that referenced
this pull request
May 14, 2019
…Status` methods Note: this is essentially the same change as in [] that triggered omg/12873 in the past, but it has feature flag that turns off it by default and tests that assert number of GCS requests when parallelism is enabled. In the worst case `getFileStatus` method can make up to 3 sequential requests to GCS to get implicit directory status. After moving implicit directory repair from list to delete/rename operations this worst case could be more frequent than before, because there higher chance to encounter implicit non-repaired directory: #156 This CL adds an option to execute these GCS requests in parallel which could reduce latency by up to 3 times. Change on 2019/05/13 by idv <idv@google.com> ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=248044068
medb
added a commit
that referenced
this pull request
May 15, 2019
…Status` methods Note: this is essentially the same change as in [] that triggered omg/12873 in the past, but it has feature flag that turns off it by default and tests that assert number of GCS requests when parallelism is enabled. In the worst case `getFileStatus` method can make up to 3 sequential requests to GCS to get implicit directory status. After moving implicit directory repair from list to delete/rename operations this worst case could be more frequent than before, because there higher chance to encounter implicit non-repaired directory: #156 This CL adds an option to execute these GCS requests in parallel which could reduce latency by up to 3 times. Change on 2019/05/13 by idv <idv@google.com> ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=248044068
mayanks
pushed a commit
to mayanks/hadoop-connectors
that referenced
this pull request
Aug 3, 2022
mayanks
pushed a commit
to mayanks/hadoop-connectors
that referenced
this pull request
Aug 3, 2022
…Status` methods Note: this is essentially the same change as in [] that triggered omg/12873 in the past, but it has feature flag that turns off it by default and tests that assert number of GCS requests when parallelism is enabled. In the worst case `getFileStatus` method can make up to 3 sequential requests to GCS to get implicit directory status. After moving implicit directory repair from list to delete/rename operations this worst case could be more frequent than before, because there higher chance to encounter implicit non-repaired directory: GoogleCloudDataproc#156 This CL adds an option to execute these GCS requests in parallel which could reduce latency by up to 3 times. Change on 2019/05/13 by idv <idv@google.com> ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=248044068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details please refer to issue #155.
Automated tests for Hadoop 2&3, and the integration tests have passed cleanly.