-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update to Guava 29.0-jre #837
Conversation
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
=========================================
Coverage 78.45% 78.46%
Complexity 610 610
=========================================
Files 96 96
Lines 2409 2410 +1
Branches 282 282
=========================================
+ Hits 1890 1891 +1
Misses 411 411
Partials 108 108
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor question.
} | ||
result.setFuture(executorService.submit(() -> consumeBytes(inputStream))); | ||
ListenableFuture<String> submit = executorService.submit(() -> consumeBytes(inputStream)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to expand this out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No semantic difference, but it makes refactoring, debugging, and updating easier. The more operations get crammed into a single statement the harder it becomes to read. In this case, it was difficult to demock without introducing local variables.
I think you need to rebase to pull in #838 to fix the cloud sdk on windows downgrade issue |
* update to Guava 28.2-jre * trivial change--http-->https-->to force CI to run again
@loosebazooka 28.2 marked several classes "Do Not Mock" which necessitated a surprisingly large number of changes.