Use service as hostname fallback to enable keyring usage on redirects #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When following redirects that don't point to one of the configured indexes
pip
will request credentials from the keyrings using thenetloc
taken from the target's location url (ref).The present implementation relies on
urlib.urlparse
to determinehostname
(which is part ofnetloc
).urlparse
requires urls to have a schema (or at least//
) in order to detect anetloc
(ref), which makes it misclassify a previously parsednetloc
as apath
(ref).I proposed falling back to using the
service
as is when ahostname
cannot be found (ex. whenservice
is just a url'snetloc
).Motivation
Using a private pypi server that redirects to a GCP Artifact Registry Python repository for certain dependencies.