chore: retire IoT samples #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify README with up to date deprecation info remove sample testing
coryan
approved these changes
Aug 1, 2023
|
|
||
| This sample app demonstrates connecting to Google Cloud IoT Core and publishing | ||
| a single message. | ||
| * <h3>Google Cloud IoT Core will be <a href="https://cloud.google.com/iot/docs/release-notes#August_16_2022">retired as of August 16, 2023</a>.</h3> |
There was a problem hiding this comment.
nit: the use of <h3> in markdown, and as a bullet point strikes me as odd... but whatevs. This README file will go away soon-ish.
There was a problem hiding this comment.
We followed the template that was implemented in another sample repo... 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IoT service is retired on August 16th. The changes update README in the iot folder to emphasis that code in this folder is no longer supported (following the message in java-docs-samples repo). Test files in the folder are updated to prevent the tests from running by adding
.deprecatedextension.