Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(pubsub-otel): add unary pull example #301

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

alevenberg
Copy link
Member

No description provided.

@alevenberg alevenberg marked this pull request as ready for review January 5, 2024 20:06
@alevenberg alevenberg requested a review from a team as a code owner January 5, 2024 20:06
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions but LGTM as-is too.

pubsub-open-telemetry/subscriber.md Outdated Show resolved Hide resolved
pubsub-open-telemetry/unary_pull_subscriber.cc Outdated Show resolved Hide resolved
pubsub-open-telemetry/unary_pull_subscriber.cc Outdated Show resolved Hide resolved
alevenberg and others added 2 commits January 5, 2024 15:16
Co-authored-by: Carlos O'Ryan <coryan@google.com>
Co-authored-by: Carlos O'Ryan <coryan@google.com>
@alevenberg alevenberg enabled auto-merge (squash) January 5, 2024 20:17
@alevenberg alevenberg merged commit 205c805 into GoogleCloudPlatform:main Jan 5, 2024
6 checks passed
@alevenberg alevenberg deleted the unary-p branch January 5, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants