Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no way to pass options to the create_server function #174

Open
anovis opened this issue Jan 10, 2022 · 2 comments
Open

There is no way to pass options to the create_server function #174

anovis opened this issue Jan 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@anovis
Copy link

anovis commented Jan 10, 2022

I would like to pass options such as workers and threads to the create_server function which then gets passed to the http server. However, currently the create_server function doesn't pass in any options

create_server(app, debug).run(host, port)

@anniefu
Copy link
Contributor

anniefu commented Apr 15, 2022

Hi @anovis, thanks for the feedback! The workers and threads selected are intentionally abstracted away. While there is benefits to be able to fine-tune concurrency settings, it is not complexity we want to expose at this time.

@anniefu anniefu removed their assignment Apr 15, 2022
@xSAVIKx
Copy link

xSAVIKx commented Aug 7, 2022

Is there any particular reason why the team would like to limit this kind of capability?

I totally agree that such tuning should not be required and there must be reasonable defaults, but what is the reason behind not letting people tune it when needed?

I assume that a workaround may be forking the repo and exposing all the relevant configs and then explicitly adding fork as a requirement to a deployed function. (I have not really tried this myself, but this looks like an option).

@josephlewis42 josephlewis42 added the enhancement New feature or request label Feb 24, 2023
xSAVIKx added a commit to xSAVIKx/functions-framework-python that referenced this issue Apr 10, 2023
I've added ability to configure Gunicorn behavior using environment variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants