Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs vs code - --signature-type or --signature_type? #3

Closed
therefromhere opened this issue Jan 10, 2020 · 1 comment · Fixed by #4
Closed

Docs vs code - --signature-type or --signature_type? #3

therefromhere opened this issue Jan 10, 2020 · 1 comment · Fixed by #4
Labels
bug Something isn't working

Comments

@therefromhere
Copy link
Contributor

Hi, the documentation says the command line flag is --signature-type (which is matches the common style of - instead of _ in command line flags), but it's actually implemented as --signature_type - which is intended?
@di di added the bug Something isn't working label Jan 10, 2020
@di
Copy link
Member

di commented Jan 10, 2020

It should be --signature-type, thanks!

therefromhere added a commit to therefromhere/functions-framework-python that referenced this issue Jan 10, 2020
@therefromhere
Fix --signature-type option
db9e234 
Resolves GoogleCloudPlatform#3
@therefromhere therefromhere mentioned this issue Jan 10, 2020
Merged
@di di closed this as completed in #4 Jan 13, 2020
di added a commit that referenced this issue Jan 13, 2020
@therefromhere @di
Fix --signature-type option (#4)
1c03225 
Resolves #3

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix --signature-type option therefromhere/functions-framework-python
2 participants
@therefromhere @di