Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a text/json writer wrapping over standard output logging writer #1056

Merged

Conversation

raj-prince
Copy link
Collaborator

@raj-prince raj-prince commented Apr 11, 2023

Description

GCSFuse doesn't writer time-stamp information while logging via os.Stdout/err writer. Added a wrapper over these writer to write all these information.

Command executed:
gcsfuse --debug_fuse --debug_fs --foreground <bucket_name> <mount_dir>

Before:

Creating a new server...
Set up root directory for bucket princer-working-dirs
Mounting file system "princer-working-dirs"...
Error while mounting gcsfuse: mountWithConn: Mount: stat /usr/local/google/home/princer/Documents/code/gcsfuse/mnt: no such file or directory
mountWithArgs: mountWithConn: Mount: stat /usr/local/google/home/princer/Documents/code/gcsfuse/mnt: no such file or directory

After:

I0411 15:33:59.567735 Opening GCS connection...
I0411 15:33:59.567950 Creating a mount at "/usr/local/google/home/princer/Documents/code/gcsfuse/mnt"
I0411 15:33:59.568341 Creating a new server...
I0411 15:33:59.568355 Set up root directory for bucket princer-working-dirs
I0411 15:34:00.900929 Mounting file system "princer-working-dirs"...
I0411 15:34:00.901060 Error while mounting gcsfuse: mountWithConn: Mount: stat /usr/local/google/home/princer/Documents/code/gcsfuse/mnt: no such file or directory
mountWithArgs: mountWithConn: Mount: stat /usr/local/google/home/princer/Documents/code/gcsfuse/mnt: no such file or directory

Link to the issue in case of a bug fix.

Testing details

  1. Manual - Manually tested.
  2. Unit tests - Automation.
  3. Integration tests - Automation.

@raj-prince raj-prince self-assigned this Apr 11, 2023
@raj-prince raj-prince merged commit 4b25949 into GoogleCloudPlatform:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants