-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List obj fix #1060
Merged
Merged
List obj fix #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raj-prince
reviewed
Apr 14, 2023
raj-prince
reviewed
Apr 18, 2023
raj-prince
reviewed
Apr 18, 2023
raj-prince
approved these changes
Apr 18, 2023
vadlakondaswetha
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug in list object method due to which some files are not listed if number of files in a directory are more than 5000 and contains one or more nested directory.
More details:
Before fix:
After fix:
Link to the issue in case of a bug fix.
This bug was identified in this issue: #1054
Testing details
a. Verified that correct number of files are listed for the exact issue specified by customer: This bug was identified in this issue: Large directory listing returns wrong results with --enable-storage-client-library=true #1054
b. Reproduced the issue for lesser number of files i.e. 5500 and verified the fix against that many files as well.
c. Also ran listing benchmarks and got similar performance.
a. Can't add unit test for testing this functionality specifically because the fake storage doesn't support ContinuationToken.