Update protobuf version as suggested in dependabot alert #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tulsishah
approved these changes
May 11, 2023
raj-prince
approved these changes
May 11, 2023
ashmeenkaur
added a commit
that referenced
this pull request
May 16, 2023
…)" This reverts commit 694c3b8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update protobuf version as suggested in dependabot alert: https://github.com/GoogleCloudPlatform/gcsfuse/pull/1105/files
Testing details
Results of perf tests (No perf regression):
Branch | File Size | Read BW | Write BW | RandRead BW | RandWrite BW |
+--------+------------+--------------+------------+-------------+--------------+
| Master | 0.25MiB | 398.16MiB/s | 2.44MiB/s | 30.4MiB/s | 2.83MiB/s |
| PR | 0.25MiB | 396.0MiB/s | 3.29MiB/s | 28.74MiB/s | 2.77MiB/s |
| | | | | | |
| | | | | | |
| Master | 48.828MiB | 4496.73MiB/s | 79.3MiB/s | 836.74MiB/s | 80.93MiB/s |
| PR | 48.828MiB | 4908.99MiB/s | 81.5MiB/s | 966.65MiB/s | 80.2MiB/s |
| | | | | | |
| | | | | | |
| Master | 976.562MiB | 4579.66MiB/s | 27.13MiB/s | 405.6MiB/s | 30.38MiB/s |
| PR | 976.562MiB | 4579.55MiB/s | 23.76MiB/s | 455.17MiB/s | 26.7MiB/s