Added timeout to golangci-lint as it is fails with timeout error #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be pull request template
CI-lint test has been failing frequently with the timeout error. This started happening after we removed the vendor directory. I've increased the timeout to 2 minutes in this PR.
Logs from old lint test: Ref: https://github.com/GoogleCloudPlatform/gcsfuse/actions/runs/4990393357/jobs/8935534530
level=info msg="[loader] Go packages loading at mode 575 (deps|files|imports|compiled_files|exports_file|name|types_sizes) took 1.011402095s"Logs from new lint test: Ref: https://github.com/GoogleCloudPlatform/gcsfuse/actions/runs/4988001530/jobs/8930307298
level=info msg="[loader] Go packages loading at mode 575 (deps|exports_file|name|types_sizes|compiled_files|files|imports) took 45.775341415s"In future if timeout of 2 minutes isn't sufficient, we should investigate use of lint cache to reduce this time.
Link to the issue in case of a bug fix.
Testing details