Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint failures #1122

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Fix lint failures #1122

merged 2 commits into from
Jun 7, 2023

Conversation

ashmeenkaur
Copy link
Collaborator

@ashmeenkaur ashmeenkaur commented May 16, 2023

Description

This CL fixes some of the lint failures we see today on the master branch.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@ashmeenkaur ashmeenkaur changed the title [do not review] Lint Fix lint failures May 26, 2023
Copy link
Collaborator

@vadlakondaswetha vadlakondaswetha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments. other changes looks good.

internal/logger/logger.go Outdated Show resolved Hide resolved
@ashmeenkaur ashmeenkaur merged commit dc95b0e into master Jun 7, 2023
@ashmeenkaur ashmeenkaur deleted the lint branch August 30, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants