Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the error variables and filehandles properly across all integration tests #1197

Merged
merged 28 commits into from
Jun 27, 2023
Merged

Handle the error variables and filehandles properly across all integration tests #1197

merged 28 commits into from
Jun 27, 2023

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Jun 22, 2023 •
edited
Loading

Description

Adding ignored file handler and error.

  1. Added clean mounted directory command to clean the bucket before testing.
  2. Added file close for closing file.
  3. After os.RemoveAll(mntDir) at the end ignore because anyway we are cleaning in the test starting.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Run all the tests for testbucket and mountedDirectory flags.(status:SUCCESS)
  2. Unit tests - NA
  3. Integration tests - Run all the tests for testbucket and mountedDirectory flags.(status:SUCCESS)

@Tulsishah Tulsishah changed the title Adding file handler and error Handle the error variables and filehandles properly across all integration tests Jun 22, 2023
@Tulsishah Tulsishah requested a review from sethiay June 23, 2023 08:32
sethiay
sethiay approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@sethiay sethiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, please check about getting all test functions of a test package programmatically and then calling cleanup before calling each test function.

@Tulsishah Tulsishah merged commit 48296dc into GoogleCloudPlatform:master Jun 27, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethiay sethiay sethiay approved these changes

@vadlakondaswetha vadlakondaswetha vadlakondaswetha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tulsishah @sethiay @vadlakondaswetha