Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete implicit dir integration test #1203

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Jun 27, 2023

Description

Adding tests for implicit directory deletion.

  1. TestDeleteNonEmptyImplicitDir
  2. TestDeleteNonEmptyImplicitSubDir
  3. TestDeleteImplicitDirWithExplicitSubDir
  4. TestDeleteImplicitDirWithExplicitSubDirInImplicitSubDir
  5. TestDeleteImplicitDirInExplicitDir
  6. TestDeleteExplicitDirWithImplicitSubDir

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Run all the tests for testbucket and mountedDirectory flags.(status:SUCCESS)
  2. Unit tests - NA
  3. Integration tests - Run all the tests for testbucket and mountedDirectory flags.(status:SUCCESS)

@raj-prince
Copy link
Collaborator

raj-prince commented Jun 28, 2023

"6. TestDeleteExplicitDirWithImplicitSubDir" - Will this test not be part of normal directory deletion test?

Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments please check.

@Tulsishah
Copy link
Collaborator Author

"6. TestDeleteExplicitDirWithImplicitSubDir" - Will this test not be part of normal directory deletion test?

In normal tests Explicit dir does not contains implicit dir. That's why I added here. For adding implicit structure we can do it from script only(gsutil)

Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please incorporate the review comments.

@Tulsishah Tulsishah merged commit a7d1640 into GoogleCloudPlatform:master Jun 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants