fix flaky log rotation test #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmeenkaur
requested review from
sethiay,
vadlakondaswetha and
raj-prince
as code owners
raj-prince
reviewed
Dec 11, 2023
raj-prince
approved these changes
Dec 11, 2023
gargnitingoogle
pushed a commit
that referenced
this pull request
Jan 4, 2024
* fix flaky log rotation test * fix lint
ashmeenkaur
added a commit
that referenced
this pull request
Jan 9, 2024
* fix flaky log rotation test * fix lint
ashmeenkaur
added a commit
that referenced
this pull request
Jan 10, 2024
* fix flaky log rotation test * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an edge case that rarely happens in log rotation integration tests where we try to stat a log file when the logs are getting rotated (the old log file getting renamed and new log file being created) as the operation is not atomic. This was causing failure in the integration tests. In order to fix the issue, we will retry the stat call once again before failing the test. If two consecutive stat calls fail, we will fail the test.
Link to the issue in case of a bug fix.
NA
Testing details