-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for key_file fstab option #182
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
case "key_file": | ||
args = append( | ||
args, | ||
"--"+strings.Replace(name, "_", "-", -1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run gofmt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did. Double-checked that now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, I had misjudged what gofmt would do here. Thanks!
Thanks for this! I've left a few comments. |
Actually this looks good as-is; will accept and touch up if I feel it needs it later. Thanks! |
This adds basic support for
key_file
fstab option, which can be used for mounting with specific credentials (like for cross-project buckets and VMs).It's quite useful, because
mount.gcsfuse
doesn't respectGOOGLE_APPLICATION_CREDENTIALS
env var, but onlygcsfuse
does. But even if it did, it would be quite hacky to make it work under systems like Puppet, for example.The option simplifies this by a lot:
it re-uses already existing
--key-file
argument forgcsfuse
.