Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for key_file fstab option #182

Merged
merged 3 commits into from
Aug 15, 2016
Merged

Support for key_file fstab option #182

merged 3 commits into from
Aug 15, 2016

Conversation

vaygr
Copy link
Contributor

@vaygr vaygr commented Aug 13, 2016

This adds basic support for key_file fstab option, which can be used for mounting with specific credentials (like for cross-project buckets and VMs).

It's quite useful, because mount.gcsfuse doesn't respect GOOGLE_APPLICATION_CREDENTIALS env var, but only gcsfuse does. But even if it did, it would be quite hacky to make it work under systems like Puppet, for example.

The option simplifies this by a lot:

my-bucket /mount/point gcsfuse rw,noauto,user,key_file=/path/to/key.json

it re-uses already existing --key-file argument for gcsfuse.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@vaygr
Copy link
Contributor Author

vaygr commented Aug 13, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

case "key_file":
args = append(
args,
"--"+strings.Replace(name, "_", "-", -1),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run gofmt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did. Double-checked that now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I had misjudged what gofmt would do here. Thanks!

@jacobsa
Copy link
Contributor

jacobsa commented Aug 15, 2016

Thanks for this! I've left a few comments.

@jacobsa
Copy link
Contributor

jacobsa commented Aug 15, 2016

Actually this looks good as-is; will accept and touch up if I feel it needs it later. Thanks!

@jacobsa jacobsa merged commit 8128102 into GoogleCloudPlatform:master Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants