Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR-1] Add flag and config to ignore interrupts #1863

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

ashmeenkaur
Copy link
Collaborator

@ashmeenkaur ashmeenkaur commented Apr 24, 2024

Description

This PR adds ignore-interrupts flag and file-system: ignore-interrupts config. The priority is given to the cli flag if both are set. The default value of the flag and config is false.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - added
  3. Integration tests - NA

@ashmeenkaur ashmeenkaur force-pushed the add_flag_to_ignore_interrupts branch from 81ee0df to 2c3a6c0 Compare April 24, 2024 09:53
@ashmeenkaur ashmeenkaur marked this pull request as ready for review April 24, 2024 11:08
@ashmeenkaur ashmeenkaur requested a review from a team as a code owner April 24, 2024 11:08
@ashmeenkaur ashmeenkaur assigned Tulsishah and unassigned Tulsishah Apr 24, 2024
@ashmeenkaur ashmeenkaur force-pushed the add_flag_to_ignore_interrupts branch from 2c3a6c0 to 50f023a Compare April 25, 2024 10:56
flags.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few minor comments.

Also, please update the description with the default value of ignore-interrupts.

@ashmeenkaur ashmeenkaur merged commit 5d34bc0 into master Apr 26, 2024
8 checks passed
@ashmeenkaur ashmeenkaur deleted the add_flag_to_ignore_interrupts branch April 26, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants