fix flaky modification time check in integration tests #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmeenkaur
changed the title
ashmeenkaur
force-pushed
the
fix-flaky-attributes-test
branch
from
aaa683b
to
32d141b
Compare
ashmeenkaur
force-pushed
the
fix-flaky-attributes-test
branch
from
32d141b
to
e99b351
Compare
raj-prince
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes flaky file and directory attributes tests.
Cause: The tests were flaky because kernel clock can be out of sync of time.Now() Ref: golang/go#33510
To handle this case, we were rounding off the times to nearest second for comparison but sometimes, edge condition can happen where pre-create time gets rounded up while the actual modification time gets rounded down.
New Fix: We will use time slop of 25 milli seconds to move pre and post create times so that file modification time lies between the range of preCreate and postCreate time.
Link to the issue in case of a bug fix.
NA
Testing details