-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement method to return bucket type from server #1898
Conversation
784ee51
to
ba3c81c
Compare
7c1f491
to
56c2096
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1898 +/- ##
==========================================
+ Coverage 61.22% 61.38% +0.16%
==========================================
Files 130 131 +1
Lines 12350 12379 +29
==========================================
+ Hits 7561 7599 +38
+ Misses 4448 4440 -8
+ Partials 341 340 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires discussion.
By mistake approved (thought it's a different PR), this requires a discussion.
dd527d5
to
5988e11
Compare
e5f37ff
to
104e8f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through with the interface level change. Added a couple of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relying on Ankita's review for unit test changes.
Description
Implemented FetchAndSetBucketType() method to get bucket type from
GetStorageLayout
(e.g. Hierarchical or NonHierarchical) and set it in bucketType.Link to the issue in case of a bug fix.
NA
Testing details