Convert gcloud operations in storage client - 1 #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1959 +/- ##
==========================================
+ Coverage 73.65% 73.89% +0.24%
==========================================
Files 97 97
Lines 10381 10486 +105
==========================================
+ Hits 7646 7749 +103
+ Misses 2398 2397 -1
- Partials 337 340 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tulsishah
force-pushed
the
cleanup_gcs_dir_fun_in_storage_client
branch
2 times, most recently
from
241c09b
to
8095f76
Compare
Tulsishah
force-pushed
the
cleanup_gcs_dir_fun_in_storage_client
branch
from
b33f0a5
to
07762e8
Compare
Tulsishah
changed the title
ashmeenkaur
reviewed
Jun 11, 2024
ashmeenkaur
reviewed
Jun 11, 2024
tools/integration_tests/util/mounting/dynamic_mounting/dynamic_mounting.go
Outdated
Show resolved
Hide resolved
Ran all the things are working fine. |
ashmeenkaur
reviewed
Jun 12, 2024
tools/integration_tests/util/mounting/dynamic_mounting/dynamic_mounting.go
Show resolved
Hide resolved
tools/integration_tests/util/mounting/dynamic_mounting/dynamic_mounting.go
Outdated
Show resolved
Hide resolved
Tulsishah
force-pushed
the
cleanup_gcs_dir_fun_in_storage_client
branch
from
c5bb3d8
to
4a92970
Compare
ashmeenkaur
reviewed
Jun 13, 2024
ashmeenkaur
reviewed
Jun 13, 2024
ashmeenkaur
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the gcloud commands for creating buckets and cleaning up directories, and replace them with storage client functions. This is because running gcloud commands in parallel sometimes leads to failures.
Link to the issue in case of a bug fix.
NA
Testing details