Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmarshal the config object #2035

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Unmarshal the config object #2035

merged 6 commits into from
Jun 20, 2024

Conversation

kislaykishore
Copy link
Collaborator

Description

Construct the config object which is derived from the commandline
args, config file and the defaults.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Construct the config object which is derived from the commandline
args, config file and the defaults.
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.

Project coverage is 71.43%. Comparing base (5eaf517) to head (0fe10d0).
Report is 1 commits behind head on master.

Files Patch % Lines
cmd/root.go 11.11% 15 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2035      +/-   ##
==========================================
- Coverage   71.55%   71.43%   -0.12%     
==========================================
  Files          98       98              
  Lines       10756    10771      +15     
==========================================
- Hits         7696     7694       -2     
- Misses       2716     2732      +16     
- Partials      344      345       +1     
Flag Coverage Δ
unittests 71.43% <11.11%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore marked this pull request as ready for review June 19, 2024 11:23
@kislaykishore kislaykishore requested a review from a team as a code owner June 19, 2024 11:23
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
@kislaykishore kislaykishore merged commit b3b62e0 into master Jun 20, 2024
12 of 13 checks passed
@kislaykishore kislaykishore deleted the viper-integ branch June 20, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants