Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add squash to config structure tags to make decoding possible… #2058

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ashmeenkaur
Copy link
Collaborator

… from legacy flagStorage & mountConfig. (#2044)"

This reverts commit d4451a4.

Reason: Found a better way to do the conversion. Did not realise earlier that with this approach, changes were required in legacy mount config and yaml v3 can't decode "squash" flags.

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

… from legacy flagStorage & mountConfig. (#2044)"

This reverts commit d4451a4.
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.

Project coverage is 72.03%. Comparing base (a1d8786) to head (4bcc5fe).

Files Patch % Lines
cfg/config.go 0.00% 55 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2058      +/-   ##
==========================================
+ Coverage   72.00%   72.03%   +0.02%     
==========================================
  Files          99       99              
  Lines       10869    10869              
==========================================
+ Hits         7826     7829       +3     
+ Misses       2711     2708       -3     
  Partials      332      332              
Flag Coverage Δ
unittests 72.03% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashmeenkaur ashmeenkaur marked this pull request as ready for review June 24, 2024 14:56
@ashmeenkaur ashmeenkaur requested review from kislaykishore and a team as code owners June 24, 2024 14:56
@ashmeenkaur ashmeenkaur merged commit c87ea13 into master Jun 24, 2024
13 checks passed
@ashmeenkaur ashmeenkaur deleted the revert_changes branch July 19, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants