Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constraints on number of args #2066

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Add constraints on number of args #2066

merged 2 commits into from
Jun 25, 2024

Conversation

kislaykishore
Copy link
Collaborator

Description

Limit the number of arguments that the root command can receive to the range [1, 2]

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - Added unit tests.
  3. Integration tests - NA

@kislaykishore kislaykishore requested a review from a team as a code owner June 25, 2024 07:51
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.98%. Comparing base (e247b84) to head (2a5967a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2066   +/-   ##
=======================================
  Coverage   71.98%   71.98%           
=======================================
  Files          99       99           
  Lines       10869    10870    +1     
=======================================
+ Hits         7824     7825    +1     
  Misses       2713     2713           
  Partials      332      332           
Flag Coverage Δ
unittests 71.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/root_test.go Outdated Show resolved Hide resolved
cmd/root_test.go Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
@kislaykishore kislaykishore merged commit 78b06ed into master Jun 25, 2024
13 checks passed
@kislaykishore kislaykishore deleted the cobra-constraint branch June 25, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants