This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Clean & lowercase filter #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedanese
reviewed
Dec 19, 2017
metadata/metadata.go
Outdated
| } | ||
|
|
||
| // Check against lowercase. | ||
| lowerPath := strings.ToLower(req.URL.Path) |
There was a problem hiding this comment.
the metadata server is case sensitive. what is this used for?
There was a problem hiding this comment.
HTTP doesn't specify case sensitivity in its spec, so in case the metadata server decides to stop being case sensitive, we should be aggressive about filtering.
metadata/metadata.go
Outdated
| // "service-accounts/<valid-service-account-or-alias>/identity". | ||
| // In particular, note that '.' may only come after '@' in the valid | ||
| // service account or alias. | ||
| concealedPattern = regexp.MustCompile("^\\/(0\\.1\\/meta\\-data|computemetadata\\/v1beta1\\/instance|computemetadata\\/v1\\/instance)/(attributes/kube-env|service-accounts/[0-9a-z_\\-]+(@[0-9a-z_\\-\\.]*)?/identity)$") |
There was a problem hiding this comment.
these are pretty painful. would it simplify things to clean the path first?
ikehz
commented
Dec 20, 2017
metadata/metadata.go
Outdated
| // "service-accounts/<valid-service-account-or-alias>/identity". | ||
| // In particular, note that '.' may only come after '@' in the valid | ||
| // service account or alias. | ||
| concealedPattern = regexp.MustCompile("^\\/(0\\.1\\/meta\\-data|computemetadata\\/v1beta1\\/instance|computemetadata\\/v1\\/instance)/(attributes/kube-env|service-accounts/[0-9a-z_\\-]+(@[0-9a-z_\\-\\.]*)?/identity)$") |
metadata/metadata.go
Outdated
| } | ||
|
|
||
| // Check against lowercase. | ||
| lowerPath := strings.ToLower(req.URL.Path) |
There was a problem hiding this comment.
HTTP doesn't specify case sensitivity in its spec, so in case the metadata server decides to stop being case sensitive, we should be aggressive about filtering.
ikehz
changed the title
|
/lgtm |
This was referenced Jan 2, 2018
Merged
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Jan 6, 2018
Automatic merge from submit-queue (batch tested with PRs 57906, 57425, 56939, 57317, 57762). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump metadata proxy and test versions **What this PR does / why we need it**: Bump metadata proxy version to v0.1.7 (to pick up GoogleCloudPlatform/k8s-metadata-proxy#13). **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note Bump metadata proxy version to v0.1.7 to pick up security fix. ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... plus some fixups: