Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Recreating HTTPS ingress should work without error #139

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

nikhiljindal
Copy link
Contributor

Fixing the issue where recreating https ingress was failing.

This was happening due to 2 reasons:

  • kubemci thought that ingress changed even when it didnt. This was happening because the in cluster ingress had the instance groups annotation. Updated the code to ignore that annotation before comparing the ingresses.
  • kubemci thought that SSL cert changed even when it didnt. This was because we were comparing the complete cert, which includes both the cert and the private key. But GCP returns a cert with empty private key (key is write only). Updated the code to compare the certificate only, which is what ingress-gce does as well: https://github.com/kubernetes/ingress-gce/blob/572e8e56a0c6ba15b0eac5ca870416c4c8fdc09c/pkg/loadbalancers/l7.go#L280

cc @csbell @madhusudancs @G-Harmon @bowei

Copy link
Contributor

@madhusudancs madhusudancs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nikhiljindal nikhiljindal merged commit 9c91aa1 into GoogleCloudPlatform:master Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants