Skip to content

Commit

Permalink
fix: Set default container limits and concurrency value (#31)
Browse files Browse the repository at this point in the history
* Set default container limits and concurrency value

* Update README.md

Update defaults to match new variables file

* Fixed limits variable block

* variables.tf formatting

* terraform fmt

* generated docs

* updates variables to null

* generated_docs

Co-authored-by: Jonathan Greger <jmgreger@google.com>
  • Loading branch information
jmgreger and Jonathan Greger authored May 17, 2022
1 parent 9d0a6fa commit 3311307
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ module "cloud_run" {
| argument | Arguments passed to the ENTRYPOINT command, include these only if image entrypoint needs arguments | `list(string)` | `[]` | no |
| certificate\_mode | The mode of the certificate (NONE or AUTOMATIC) | `string` | `"NONE"` | no |
| container\_command | Leave blank to use the ENTRYPOINT command defined in the container image, include these only if image entrypoint should be overwritten | `list(string)` | `[]` | no |
| container\_concurrency | Concurrent request limits to the service | `number` | `0` | no |
| container\_concurrency | Concurrent request limits to the service | `number` | `null` | no |
| domain\_map\_annotations | Annotations to the domain map | `map(string)` | `{}` | no |
| domain\_map\_labels | A set of key/value label pairs to assign to the Domain mapping | `map(string)` | `{}` | no |
| encryption\_key | CMEK encryption key self-link expected in the format projects/PROJECT/locations/LOCATION/keyRings/KEY-RING/cryptoKeys/CRYPTO-KEY. | `string` | `null` | no |
Expand All @@ -51,7 +51,7 @@ module "cloud_run" {
| force\_override | Option to force override existing mapping | `bool` | `false` | no |
| generate\_revision\_name | Option to enable revision name generation | `bool` | `true` | no |
| image | GCR hosted image URL to deploy | `string` | n/a | yes |
| limits | Resource limits to the container | `map(string)` | `{}` | no |
| limits | Resource limits to the container | `map(string)` | `null` | no |
| location | Cloud Run service deployment location | `string` | n/a | yes |
| members | Users/SAs to be given invoker access to the service | `list(string)` | `[]` | no |
| ports | Port which the container listens to (http1 or h2c) | <pre>object({<br> name = string<br> port = number<br> })</pre> | <pre>{<br> "name": "http1",<br> "port": 8080<br>}</pre> | no |
Expand Down
4 changes: 2 additions & 2 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ variable "encryption_key" {
variable "container_concurrency" {
type = number
description = "Concurrent request limits to the service"
default = 0
default = null
}

variable "timeout_seconds" {
Expand Down Expand Up @@ -131,7 +131,7 @@ variable "volumes" {
variable "limits" {
type = map(string)
description = "Resource limits to the container"
default = {}
default = null
}
variable "requests" {
type = map(string)
Expand Down

0 comments on commit 3311307

Please sign in to comment.