fix!: replace random_id with random_string to increase number of possible access levels #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble acceess levels
daniel-cit
requested review from
prabhu34,
anamer,
gtsorbo and
a team
as code owners
|
/gcbrun |
apeabody
changed the title
daniel-cit
changed the title
apeabody
approved these changes
Apr 8, 2024
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the random_id used in the composition of the names of the Access Level and Perimeter created in the
secure-serverless-harnessso that instead of a space with[0-9a-f](4)we will have[0-9a-z](4)which will decrease the chance of a collision of names when running tests