Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose secure-cloud-run-core module timeout_seconds input to secure_cloud_run module #225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: expose secure-cloud-run-core module timeout_seconds input to secure_cloud_run module #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04844b2
fix: expose `secure-cloud-run-core` module `timeout_seconds` input to…
jeffsays Aug 6, 2024
20db9d5
Merge branch 'main' into expose-secure-cloud-run-timeout-seconds-var
bharathkkb Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/secure-cloud-run/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ module "secure_cloud_run" {
| shared\_vpc\_name | Shared VPC name which is going to be re-used to create Serverless Connector. | `string` | n/a | yes |
| ssl\_certificates | A object with a list of domains to auto-generate SSL certificates or a list of SSL Certificates self-links in the pattern `projects/<PROJECT-ID>/global/sslCertificates/<CERT-NAME>` to be used by Load Balancer. | <pre>object({<br> ssl_certificates_self_links = list(string)<br> generate_certificates_for_domains = list(string)<br> })</pre> | n/a | yes |
| subnet\_name | Subnet name to be re-used to create Serverless Connector. | `string` | `null` | no |
| timeout\_seconds | Timeout for each request | `number` | `120` | no |
| verified\_domain\_name | List of Custom Domain Name | `list(string)` | `[]` | no |
| volumes | [Beta] Volumes needed for environment variables (when using secret). | <pre>list(object({<br> name = string<br> secret = set(object({<br> secret_name = string<br> items = map(string)<br> }))<br> }))</pre> | `[]` | no |
| vpc\_egress\_value | Sets VPC Egress firewall rule. Supported values are all-traffic, all (deprecated), and private-ranges-only. all-traffic and all provide the same functionality. all is deprecated but will continue to be supported. Prefer all-traffic. | `string` | `"private-ranges-only"` | no |
Expand Down
1 change: 1 addition & 0 deletions modules/secure-cloud-run/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ module "cloud_run_core" {
vpc_egress_value = var.vpc_egress_value
min_scale_instances = var.min_scale_instances
max_scale_instances = var.max_scale_instances
timeout_seconds = var.timeout_seconds
volumes = var.volumes
ssl_certificates = var.ssl_certificates

Expand Down
6 changes: 6 additions & 0 deletions modules/secure-cloud-run/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,12 @@ variable "cloud_armor_policies_name" {
default = null
}

variable "timeout_seconds" {
type = number
description = "Timeout for each request"
default = 120
}

variable "verified_domain_name" {
type = list(string)
description = "List of Custom Domain Name"
Expand Down