scheduler test case

GoogleContainerTools · Mar 18, 2021 · b8782ab · b8782ab
1 parent 8072134
commit b8782ab
Showing 1 changed file with 19 additions and 2 deletions.
diff --git a/pkg/skaffold/build/scheduler_test.go b/pkg/skaffold/build/scheduler_test.go
@@ -38,6 +38,7 @@ import (
 func TestGetBuild(t *testing.T) {
 	tests := []struct {
 		description   string
+		artifact      *latest.Artifact
 		buildArtifact ArtifactBuilder
 		tags          tag.ImageTags
 		expectedTag   string
@@ -46,6 +47,7 @@ func TestGetBuild(t *testing.T) {
 	}{
 		{
 			description: "build succeeds",
+			artifact:    &latest.Artifact{ImageName: "skaffold/image1"},
 			buildArtifact: func(ctx context.Context, out io.Writer, artifact *latest.Artifact, tag string) (string, error) {
 				out.Write([]byte("build succeeds"))
 				return fmt.Sprintf("%s@sha256:abac", tag), nil
@@ -57,8 +59,23 @@ func TestGetBuild(t *testing.T) {
 			expectedTag: "skaffold/image1:v0.0.1@sha256:abac",
 			expectedOut: "Building [skaffold/image1]...\nbuild succeeds",
 		},
+		{
+			description: "build succeeds with no digest",
+			artifact:    &latest.Artifact{ImageName: "skaffold/image1", NoDigest: true},
+			buildArtifact: func(ctx context.Context, out io.Writer, artifact *latest.Artifact, tag string) (string, error) {
+				out.Write([]byte("build succeeds with no digest"))
+				return fmt.Sprintf("%s@sha256:abac", tag), nil
+			},
+			tags: tag.ImageTags{
+				"skaffold/image1": "skaffold/image1:v0.0.1",
+				"skaffold/image2": "skaffold/image2:v0.0.2",
+			},
+			expectedTag: "skaffold/image1:v0.0.1",
+			expectedOut: "Building [skaffold/image1]...\nbuild succeeds with no digest",
+		},
 		{
 			description: "build fails",
+			artifact:    &latest.Artifact{ImageName: "skaffold/image1"},
 			buildArtifact: func(ctx context.Context, out io.Writer, artifact *latest.Artifact, tag string) (string, error) {
 				return "", fmt.Errorf("build fails")
 			},
@@ -70,6 +87,7 @@ func TestGetBuild(t *testing.T) {
 		},
 		{
 			description: "tag not found",
+			artifact:    &latest.Artifact{ImageName: "skaffold/image1"},
 			tags:        tag.ImageTags{},
 			expectedOut: "Building [skaffold/image1]...\n",
 			shouldErr:   true,
@@ -79,8 +97,7 @@ func TestGetBuild(t *testing.T) {
 		testutil.Run(t, test.description, func(t *testutil.T) {
 			out := new(bytes.Buffer)
 
-			artifact := &latest.Artifact{ImageName: "skaffold/image1"}
-			got, err := performBuild(context.Background(), out, test.tags, artifact, test.buildArtifact)
+			got, err := performBuild(context.Background(), out, test.tags, test.artifact, test.buildArtifact)
 
 			t.CheckErrorAndDeepEqual(test.shouldErr, err, test.expectedTag, got)
 			t.CheckDeepEqual(test.expectedOut, out.String())