Skip to content

Commit

Permalink
Remove rel="noopener" from all links (#13725)
Browse files Browse the repository at this point in the history
  • Loading branch information
swissspidy committed Jun 6, 2024
1 parent b75b599 commit 8d106ec
Show file tree
Hide file tree
Showing 10 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions includes/Admin/PluginRowMeta.php
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ public function get_plugin_row_meta( $meta, string $plugin_file ) {
return $meta;
}
$additional_meta = [
'<a href="https://wordpress.org/support/plugin/web-stories/" target="_blank" rel="noreferrer noopener">' . esc_html__( 'Contact support', 'web-stories' ) . '</a>',
'<a href="https://wordpress.org/support/plugin/web-stories/reviews/#new-post" target="_blank" rel="noreferrer noopener">' . esc_html__( 'Leave review', 'web-stories' ) . '</a>',
'<a href="https://wordpress.org/support/plugin/web-stories/" target="_blank" rel="noreferrer">' . esc_html__( 'Contact support', 'web-stories' ) . '</a>',
'<a href="https://wordpress.org/support/plugin/web-stories/reviews/#new-post" target="_blank" rel="noreferrer">' . esc_html__( 'Leave review', 'web-stories' ) . '</a>',
];

return [ ...$meta, ...$additional_meta ];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export function QuickTip({
a: (
<Link
size={TextSize.Small}
rel="noreferrer noopener"
rel="noreferrer"
target="_blank"
href={href}
/>
Expand Down
2 changes: 1 addition & 1 deletion packages/story-editor/src/components/hotlinkModal/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export function CORSMessage() {
size={TextSize.Medium}
href={DOCS_URL}
target="_blank"
rel="noopener noreferrer"
rel="noreferrer"
onClick={onDocsClick}
/>
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ function SlugPanel({ nameOverride }) {
)}
<LinkContainer>
<Link
rel="noopener noreferrer"
rel="noreferrer"
target="_blank"
href={link}
size={TextSize.Small}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ function LinkRelations({ rel, onChangeRel }) {
</CheckboxWrapper>
))}
<Link
rel="noopener noreferrer"
rel="noreferrer"
target="_blank"
href={relHelpLink}
size={TextSize.XSmall}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function CorsCheckFailed({ isOpen, onClose }) {
size={TextSize.Small}
href={DOCS_URL}
target="_blank"
rel="noopener noreferrer"
rel="noreferrer"
onClick={onDocsClick}
/>
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ function PublishPanel({ nameOverride }) {
<Required />
{canManageSettings && (
<Link
rel="noopener noreferrer"
rel="noreferrer"
target="_blank"
href={dashboardSettingsLink}
size={TextSize.XSmall}
Expand Down Expand Up @@ -460,7 +460,7 @@ function PublishPanel({ nameOverride }) {
</RevisionsLabel>
{revisionLink && revisionId ? (
<Link
rel="noopener noreferrer"
rel="noreferrer"
target="_blank"
href={addQueryArgs(revisionLink, { revision: revisionId })}
size={TextSize.XSmall}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ function PostPublishDialog() {
size={TextSize.Small}
href={storyURL}
target="_blank"
rel="noopener noreferrer"
rel="noreferrer"
onClick={onViewStoryClick}
/>
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function StatusCheckFailed({ isOpen, onClose }) {
size={TextSize.Small}
href={SUPPORT_URL}
target="_blank"
rel="noopener noreferrer"
rel="noreferrer"
onClick={onSupportClick}
/>
),
Expand Down
4 changes: 2 additions & 2 deletions tests/phpunit/integration/tests/Admin/PluginRowMeta.php
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ public function test_get_plugin_row_meta(): void {
$expected_meta = array_merge(
$initial_meta,
[
'<a href="https://wordpress.org/support/plugin/web-stories/" target="_blank" rel="noreferrer noopener">Contact support</a>',
'<a href="https://wordpress.org/support/plugin/web-stories/reviews/#new-post" target="_blank" rel="noreferrer noopener">Leave review</a>',
'<a href="https://wordpress.org/support/plugin/web-stories/" target="_blank" rel="noreferrer">Contact support</a>',
'<a href="https://wordpress.org/support/plugin/web-stories/reviews/#new-post" target="_blank" rel="noreferrer">Leave review</a>',
]
);

Expand Down

0 comments on commit 8d106ec

Please sign in to comment.