-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make snackbar message readable #4145
Conversation
Size Change: +5.91 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #4145 +/- ##
===========================================
+ Coverage 69.87% 82.53% +12.66%
===========================================
Files 792 817 +25
Lines 13936 14271 +335
===========================================
+ Hits 9738 11779 +2041
+ Misses 4198 2492 -1706
Flags with carried forward coverage won't be shown. Click here to find out more.
|
https://percy.io/google/web-stories-wp-storybook Looks good, I'm just thinking about cropping the whitespace (more effort) or using smaller viewport. |
Mostly looks good, yes, but it also helps catch lots of places where the stories are broken or not really good for a screenshot (wrong background, needs interaction, etc) Left a bunch of comments on Percy. Maybe something to address beforehand / in this PR? |
As discussed today, we will get back to testing (Storybook+Percy) after the stable release. #4195 |
Summary
We want to snapshot components in isolation, testing Percy for Storybook for this job.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
Fixes #4114