Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make snackbar message readable #4145

Merged
merged 6 commits into from
Aug 25, 2020
Merged

Make snackbar message readable #4145

merged 6 commits into from
Aug 25, 2020

Conversation

merapi
Copy link
Contributor

@merapi merapi commented Aug 20, 2020

Summary

We want to snapshot components in isolation, testing Percy for Storybook for this job.

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions


Fixes #4114

@google-cla google-cla bot added the cla: yes label Aug 20, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2020

Size Change: +5.91 kB (0%)

Total Size: 1.16 MB

Filename Size Change
assets/js/edit-story.js 488 kB +4.15 kB (0%)
assets/js/stories-dashboard.js 513 kB +1.83 kB (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 268 B 0 B
assets/css/stories-dashboard.css 305 B 0 B
assets/css/web-stories-embed-block.css 515 B 0 B
assets/js/chunk-web-stories-template-0-********************.js 10.2 kB 0 B
assets/js/chunk-web-stories-template-1-********************.js 10.3 kB 0 B
assets/js/chunk-web-stories-template-2-********************.js 10 kB 0 B
assets/js/chunk-web-stories-template-3-********************.js 10.5 kB 0 B
assets/js/chunk-web-stories-template-4-********************.js 10.6 kB 0 B
assets/js/chunk-web-stories-template-5-********************.js 6.86 kB -70 B (1%)
assets/js/chunk-web-stories-template-6-********************.js 9.91 kB 0 B
assets/js/chunk-web-stories-template-7-********************.js 9.78 kB 0 B
assets/js/web-stories-activation-notice.js 63.6 kB 0 B
assets/js/web-stories-embed-block.js 16.9 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #4145 into main will increase coverage by 12.66%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4145       +/-   ##
===========================================
+ Coverage   69.87%   82.53%   +12.66%     
===========================================
  Files         792      817       +25     
  Lines       13936    14271      +335     
===========================================
+ Hits         9738    11779     +2041     
+ Misses       4198     2492     -1706     
Flag Coverage Δ
#karmatests 70.19% <0.00%> (+41.13%) ⬆️
#unittests 65.42% <0.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
assets/src/edit-story/app/snackbar/snackbar.js 45.00% <0.00%> (ø)
...-story/app/story/useStoryReducer/reducers/utils.js 69.69% <0.00%> (-30.31%) ⬇️
...ts/src/dashboard/app/views/editorSettings/index.js 71.87% <0.00%> (-28.13%) ⬇️
assets/src/animation/parts/index.js 35.29% <0.00%> (-14.71%) ⬇️
assets/src/dashboard/app/api/useSettingsApi.js 70.83% <0.00%> (-10.42%) ⬇️
...p/story/useStoryReducer/reducers/deleteElements.js 96.42% <0.00%> (-3.58%) ⬇️
assets/src/edit-story/elements/media/edit.js 28.57% <0.00%> (-3.43%) ⬇️
assets/src/dashboard/app/views/toaster/index.js 75.00% <0.00%> (-1.93%) ⬇️
includes/Dashboard.php 20.53% <0.00%> (-0.19%) ⬇️
assets/src/edit-story/types.js 100.00% <0.00%> (ø)
... and 210 more

@merapi
Copy link
Contributor Author

merapi commented Aug 21, 2020

https://percy.io/google/web-stories-wp-storybook

Looks good, I'm just thinking about cropping the whitespace (more effort) or using smaller viewport.

image

@swissspidy
Copy link
Collaborator

Mostly looks good, yes, but it also helps catch lots of places where the stories are broken or not really good for a screenshot (wrong background, needs interaction, etc)

Left a bunch of comments on Percy. Maybe something to address beforehand / in this PR?

@swissspidy swissspidy added the Type: Infrastructure Changes impacting testing infrastructure or build tooling label Aug 21, 2020
@merapi merapi changed the title Snapshot components in isolation Make snackbar message readable Aug 24, 2020
@merapi
Copy link
Contributor Author

merapi commented Aug 24, 2020

As discussed today, we will get back to testing (Storybook+Percy) after the stable release. #4195

@merapi merapi marked this pull request as ready for review August 24, 2020 21:04
@merapi merapi requested review from barklund and miina August 24, 2020 21:05
@merapi merapi merged commit 054afb2 into main Aug 25, 2020
@merapi merapi deleted the fix/snackback-message branch August 25, 2020 11:10
@merapi merapi restored the fix/snackback-message branch August 31, 2020 16:22
@merapi merapi deleted the fix/snackback-message branch August 31, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snackbar message is unreadable
3 participants