Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : 티켓생성시 validation추가, 무료티켓에 유료 옵션 적용불가 #467

Merged
merged 6 commits into from
Feb 27, 2023

Conversation

kim-wonjin
Copy link
Member

개요

작업사항

  • 티켓 생성 시 음수 재고 불가 처리
  • 티켓 생성 시 두둥티켓 제외 계좌정보 무시
  • 무료티켓에 유료 옵션 적용 불가 처리
{
  "success": false,
  "status": 400,
  "code": "Item_Option_Group_400_4",
  "reason": "유료 옵션을 적용할 수 없습니다.",
  "timeStamp": "2023-02-27T13:00:27.725873",
  "path": "http://localhost:8080/api/v1/events/1/ticketItems/18/option"
}

변경로직

  • 내용을 적어주세요.

# Conflicts:
#	DuDoong-Api/src/main/java/band/gosrock/api/ticketItem/dto/request/CreateTicketItemRequest.java
#	DuDoong-Api/src/main/java/band/gosrock/api/ticketItem/dto/response/TicketItemResponse.java
#	DuDoong-Domain/src/main/java/band/gosrock/domain/common/vo/AccountInfoVo.java
#	DuDoong-Domain/src/main/java/band/gosrock/domain/domains/ticket_item/domain/TicketItem.java
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 447 Code Smells

21.4% 21.4% Coverage
0.7% 0.7% Duplication

Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kim-wonjin kim-wonjin merged commit 839c468 into dev Feb 27, 2023
@kim-wonjin kim-wonjin deleted the fix/454-ticket-item-validation branch February 27, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛[BUG] 티켓 생성시 밸리데이션 추가
3 participants