feat : 주문취소 feign retryer bean 추가 #564
Merged
+94
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengminy
requested review from
ImNM,
sanbonai06,
cofls6581 and
kim-wonjin
as code owners
sanbonai06
reviewed
Jul 9, 2023
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| @FeignClient( | |||
| name = "PaymentsCancelClient", | |||
| url = "https://api.tosspayments.com", | |||
| url = "${feign.toss.url}", | |||
sanbonai06
reviewed
Jul 9, 2023
Comment on lines
20
to
28
| private static final long PERIOD = 100L; | ||
| private static final long MAX_PERIOD = TimeUnit.SECONDS.toMillis(3L); | ||
| private static final int MAX_ATTEMPTS = 3; | ||
|
|
||
| @Bean | ||
| Retryer.Default retryer() { | ||
| return new Retryer.Default(PERIOD, MAX_PERIOD, MAX_ATTEMPTS); | ||
| } | ||
|
|
sanbonai06
reviewed
Jul 9, 2023
Comment on lines
20
to
43
| // private final static String IDEMPOTENCY_KEY = "idempotency-key"; | ||
| // private final static String PAYMENT_KEY = "1234"; | ||
| // private final static CancelPaymentsRequest REQUEST = | ||
| // CancelPaymentsRequest.builder().cancelReason("test").build(); | ||
| // @Autowired | ||
| // private PaymentsCancelClient paymentsCancelClient; | ||
| // | ||
| // @Test | ||
| // public void 주문취소_실패시_멱등성_테스트() { | ||
| // final String URL = "/v1/payments/" + PAYMENT_KEY + "/cancel"; | ||
| // // given | ||
| // stubFor(post(urlEqualTo(URL)) | ||
| // .willReturn(aResponse() | ||
| // .withStatus(HttpStatus.SERVICE_UNAVAILABLE))); | ||
| // | ||
| // // when | ||
| // Throwable exception = catchThrowable( | ||
| // () -> paymentsCancelClient.execute(IDEMPOTENCY_KEY, PAYMENT_KEY, REQUEST)); | ||
| // | ||
| // // then | ||
| // assertThat(exception).isInstanceOf(RetryableException.class); | ||
| // verify(3, postRequestedFor(urlEqualTo(URL))); | ||
| // } | ||
| } |
|
Kudos, SonarCloud Quality Gate passed! |
ImNM
approved these changes
Jul 9, 2023
Comment on lines
28
to
+31
| @Override | ||
| public Exception decode(String methodKey, Response response) { | ||
| TossPaymentsErrorDto body = TossPaymentsErrorDto.from(response); | ||
| try { | ||
| PaymentsCancelErrorCode paymentsCancelErrorCode = | ||
| FeignException exception = feign.FeignException.errorStatus(methodKey, response); |
There was a problem hiding this comment.
에러 디코더는 도는게 맞는데
TossPaymentsErrorDto 를 먼저해버려서
응답값 파싱중에
unhandleException 먼저 되버린 문제였습니다!
바디파싱은 뒤로미루고
500 번대 먼저 캐치해서 리트라이 했어요
There was a problem hiding this comment.
response 를 먼저 읽어서 그렇군요 확인입니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경로직