Allow string CA path values for gitlab.verify_ssl #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bugwarrior.services.gitlab.GitlabClient._fetch(), the verify_ssl configuration value is given as the requests verify parameter, which can either be a boolean or a path to a CA certificate bundle: https://docs.python-requests.org/en/latest/user/advanced/#ssl-cert-verification Simply extending the configuration type to include bugwarrior.config.ExpandedPath allows users to use non-public certificate authorities without disabling TLS verification entirely. This is preferable to setting the REQUESTS_CA_BUNDLE environment variable, which may interfere with other services using different certificate authorities.
This fixes the docs build which was failing in CI.
ryneeverett
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
bugwarrior.services.gitlab.GitlabClient._fetch(), theverify_sslconfiguration value is given as the requestsverifyparameter, which can either be a boolean or a path to a CA certificate bundle:https://docs.python-requests.org/en/latest/user/advanced/#ssl-cert-verification
Simply extending the configuration type to include
bugwarrior.config.ExpandedPathallows users to use non-public certificate authorities without disabling TLS verification entirely. This is preferable to setting theREQUESTS_CA_BUNDLEenvironment variable, which may interfere with other services using different certificate authorities.