1.0.9.3 - Docker Fix & Test Cases #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the last update, I had left an issue with the parsing of docker configuration variables for Application variables. This fixes the possible null, the option of having steam or battle metrics, or none. I have built test cases around this parsing logic, so that in the future if I break something I know before releasing it. Please note that this issue doesn't extend to the standard configuration as JSON hold a specific format for dictionaries that would cause the parser to fail. I also moved the logic for setting channel name to an extension method.
…yWolfNotAmused/PlayerCountDiscordBot into test-cases-and-docker-fix
…r-fix Test Cases and Docker fix
GravityWolfNotAmused
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the last update, I left an issue with the parsing of docker configuration variables for Application variables. This fixes the possible null, the option of having steam or battle metrics, or none.
I have built test cases around this parsing logic, so that in the future if I break something I know before releasing it. Please note that this issue doesn't extend to the standard configuration as JSON holds a specific format for dictionaries that would cause the parser to fail.
I also moved the logic for setting the channel name to an extension method.
Also!
I have moved all of the documentation to the wiki. It's easier that way ;)