This repository has been archived by the owner on Mar 21, 2023. It is now read-only.
Fix handling of "match all"/"match either" #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernd
suggested changes
Jun 29, 2017
| private final boolean cachedIterators; | ||
|
|
||
| @AssistedInject | ||
| public State(@Assisted ImmutableMap<String, Pipeline> currentPipelines, | ||
| @Assisted ImmutableSetMultimap<String, Pipeline> streamPipelineConnections, | ||
| @Nullable @Assisted ClassLoader commonClassLoader, |
There was a problem hiding this comment.
This breaks the server startup. How did this work in your setup?
2017-06-29 18:06:20,707 ERROR: org.graylog2.bootstrap.CmdLineTool - Guice error (more detail on log level debug): org.graylog.plugins.pipelineprocessor.processors.PipelineInterpreter$State has @AssistedInject constructors, but none of them match the parameters in method org.graylog.plugins.pipelineprocessor.processors.PipelineInterpreter$State$Factory.newState(). Unable to create AssistedInject factory.
Disconnected from the target VM, address: '127.0.0.1:44391', transport: 'socket'
com.google.inject.CreationException: Unable to create injector, see the following errors:
1) No implementation for org.graylog.plugins.pipelineprocessor.processors.PipelineInterpreter$State$Factory was bound.
while locating org.graylog.plugins.pipelineprocessor.processors.PipelineInterpreter$State$Factory
for the 9th parameter of org.graylog.plugins.pipelineprocessor.processors.ConfigurationStateUpdater.<init>(ConfigurationStateUpdater.java:74)
while locating org.graylog.plugins.pipelineprocessor.processors.ConfigurationStateUpdater
for the 3rd parameter of org.graylog.plugins.pipelineprocessor.processors.PipelineInterpreter.<init>(PipelineInterpreter.java:83)
at org.graylog2.plugin.PluginModule.addMessageProcessor(PluginModule.java:152) (via modules: org.graylog2.shared.bindings.PluginBindings -> org.graylog.plugins.pipelineprocessor.PipelineProcessorModule)
2) org.graylog.plugins.pipelineprocessor.processors.PipelineInterpreter$State has @AssistedInject constructors, but none of them match the parameters in method org.graylog.plugins.pipelineprocessor.processors.PipelineInterpreter$State$Factory.newState(). Unable to create AssistedInject factory.
while locating org.graylog.plugins.pipelineprocessor.processors.PipelineInterpreter$State
at org.graylog.plugins.pipelineprocessor.processors.PipelineInterpreter$State$Factory.newState(PipelineInterpreter.java:1)
2 errors
at com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:470)
at com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
at com.google.inject.Guice.createInjector(Guice.java:99)
at org.graylog2.shared.bindings.GuiceInjectorHolder.createInjector(GuiceInjectorHolder.java:34)
at org.graylog2.bootstrap.CmdLineTool.setupInjector(CmdLineTool.java:379)
at org.graylog2.bootstrap.CmdLineTool.run(CmdLineTool.java:193)
at org.graylog2.bootstrap.Main.main(Main.java:44)
There was a problem hiding this comment.
There were some uncommitted changes in my working directory. 😞
The pipeline interpreter had a bug regarding the handling of the "match all" and "match either" statements which caused pipelines containing stages with "match all" to continue processing even if not all rules in the stage were executed. Fixes Graylog2/graylog2-server#3924
joschi
force-pushed
the
graylog2-server-issue-3924
branch
from
efdb4f6
to
dad3774
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipeline interpreter had a bug regarding the handling of the "match all" and "match either" statements which caused pipelines containing stages with "match all" to continue processing even if not all rules in the stage were executed.
Fixes Graylog2/graylog2-server#3924