This repository has been archived by the owner on Mar 21, 2023. It is now read-only.
add key-value parsing function #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public KeyValue() { | ||
| valueParam = string("value").build(); | ||
| splitParam = string("delimiter", CharMatcher.class).transform(CharMatcher::anyOf).optional().build(); |
There was a problem hiding this comment.
Since there is possibly more than 1 delimiter, the parameter should be called delimiters.
|
@kroepke This also needs a rebase, thanks! |
add license header
|
@bernd pushed |
| @Override | ||
| public Map<String, String> evaluate(FunctionArgs args, EvaluationContext context) { | ||
| final String value = valueParam.required(args, context); | ||
| if (value == null) { |
There was a problem hiding this comment.
Does it make sense to short cut here for an empty value as well? (i.e. value="" or value=" ")
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #38