Skip to content

Commit

Permalink
Add missing Input IDs (#226)
Browse files Browse the repository at this point in the history
  • Loading branch information
edmundoa authored and joschi committed Nov 10, 2017
1 parent 5760c85 commit e5c8222
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion plugin/src/web/pipelines/StageForm.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ const StageForm = React.createClass({
onChange={this._onChange}
checked={!this.state.stage.match_all} />

<Input label="Stage rules"
<Input id="stage-rules-select"
label="Stage rules"
help={rulesHelp}>
<SelectableList options={this._getFormattedOptions(this.state.rules)} isLoading={!this.state.rules}
onChange={this._onRulesChange} selectedOptions={this.state.stage.rules} />
Expand Down
4 changes: 2 additions & 2 deletions plugin/src/web/rules/RuleForm.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ const RuleForm = React.createClass({
let pipelinesUsingRule;
if (!this.props.create) {
pipelinesUsingRule = (
<Input label="Used in pipelines" help="Pipelines that use this rule in one or more of their stages.">
<Input id="used-in-pipelines" label="Used in pipelines" help="Pipelines that use this rule in one or more of their stages.">
<div className="form-control-static">
{this._formatPipelinesUsingRule()}
</div>
Expand All @@ -174,7 +174,7 @@ const RuleForm = React.createClass({

{pipelinesUsingRule}

<Input label="Rule source" help="Rule source, see quick reference for more information.">
<Input id="rule-source-editor" label="Rule source" help="Rule source, see quick reference for more information.">
<div style={{ border: '1px solid lightgray', borderRadius: 5 }}>
<AceEditor
mode="text"
Expand Down

0 comments on commit e5c8222

Please sign in to comment.