Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer in-place migration handling #20366

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Sep 5, 2024

  • Migration check for node.lock to prevent parallel run of a native opensearch and the datanode opensearch
  • Safer preflight config result handling, without call side effects

Motivation and Context

Make the in-place migration more resilient.

How Has This Been Tested?

Manually + added unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora changed the title Remove side effects, set preflight finished onexit in migration Safer in-place migration handling Sep 5, 2024
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this does not really cover the first use case to prevent the parallel run.
The check checks if the lock file is writable, which in my test is the case and starts up data node.
Also, putting this in preflight will probably prevent data node from starting up altogether even though we might want it to start up for configuring it for migration and doing the compatibility check. The check should be placed at OS startup, or better, as a guard into the migration wizard.

@todvora todvora marked this pull request as draft September 18, 2024 12:41
@todvora todvora marked this pull request as ready for review September 24, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants