-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safer in-place migration handling #20366
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this does not really cover the first use case to prevent the parallel run.
The check checks if the lock file is writable, which in my test is the case and starts up data node.
Also, putting this in preflight will probably prevent data node from starting up altogether even though we might want it to start up for configuring it for migration and doing the compatibility check. The check should be placed at OS startup, or better, as a guard into the migration wizard.
Motivation and Context
Make the in-place migration more resilient.
How Has This Been Tested?
Manually + added unit tests
Types of changes
Checklist: