Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stream categories to search replay #20380

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Add stream categories to search replay #20380

merged 4 commits into from
Sep 13, 2024

Conversation

kingzacko1
Copy link
Contributor

Description

Adds Stream Categories of searches to the URL and Search Replay logic

Motivation and Context

maintain stream categories when navigating through history like streams currently are

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

danotorrey
danotorrey approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@danotorrey danotorrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests successfully (with exception of auto-filling categories from URL in dropdown, which is planned for subsequent PR).

simonychuang
simonychuang approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@simonychuang simonychuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ryan-carroll-graylog
ryan-carroll-graylog approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@ryan-carroll-graylog ryan-carroll-graylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and didn't hit any regression issues in testing

@kingzacko1 kingzacko1 merged commit f41bc23 into master Sep 13, 2024
7 checks passed
@kingzacko1 kingzacko1 deleted the include-stream-categories-in-replay-search branch September 13, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danotorrey danotorrey danotorrey approved these changes

@simonychuang simonychuang simonychuang approved these changes

@ryan-carroll-graylog ryan-carroll-graylog ryan-carroll-graylog approved these changes

@zeeklop zeeklop Awaiting requested review from zeeklop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kingzacko1 @danotorrey @simonychuang @ryan-carroll-graylog