Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update appsettings with default datasources #330

Closed

Conversation

helayoty
Copy link

@helayoty helayoty commented Apr 13, 2023

Pull Request

Issue Number: #329

Summary

Update appsettings.json.

Changes

  • Update the default emission and electricity datasources.
  • Update the AllowedHosts/Urls.

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

No.

If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.

Is this a breaking change?

If yes, what workflow does this break?

Anything else?

Other comments, collaborators, etc.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

This PR Closes #329

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@danuw
Copy link
Collaborator

danuw commented May 16, 2023

hi @helayoty, sorry for delay in reviewing this. Would you be able to provide a bit more detail on what the issue this PR solves and any other details that can help move this forward please?

cc @Willmish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: default appsettings datasources are not working
2 participants