Update Muzzle Flashes to properly use Overlay Sprites #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly to try and prevent a divide by 0 error when it sets deg to 1/degree, which somehow could resolve into a 0? Either way the rest of the math here is a combination of the original values as well as some taken from the Brontornis Rifle instead of the Boss Rifle.
|
It's been long enough, and there's also the Scorpion Scope logic change also lumped in now, so might as well merge this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It always bugged me that the muzzle flashes were just another frame of animation rather than being overlaid like the rest of the weapons across HDest and its addons, so this updates all of them to match.
If there's a better way to handle some of these, please let me know and I'll see what I can do to fix them.