Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport giscus comment system #277

Merged
merged 6 commits into from
Oct 15, 2021
Merged

Add suport giscus comment system #277

merged 6 commits into from
Oct 15, 2021

Conversation

eyllanesc
Copy link
Contributor

This PR implements the giscus comment system (#276)

I have not been able to test it since if it is executed locally the commenting system is deactivated.

@vercel
Copy link

vercel bot commented Oct 15, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @HEIGE-PCloud on Vercel.

@HEIGE-PCloud first needs to authorize it.

@HEIGE-PCloud
Copy link
Owner

Hello, thanks for your contribution!

To activate the comment system in local environment, run npm run start-production under DoIt folder, then you will be able to test it locally.

You probably want to run npm run build as well since the theme.min.js need to be recompiled after modifying theme.js.

Thanks!

@HEIGE-PCloud HEIGE-PCloud added the enhancement Enhance existing features label Oct 15, 2021
@HEIGE-PCloud HEIGE-PCloud added this to the v0.2.13 milestone Oct 15, 2021
@HEIGE-PCloud HEIGE-PCloud linked an issue Oct 15, 2021 that may be closed by this pull request
@eyllanesc
Copy link
Contributor Author

@HEIGE-PCloud I have already been able to test and it works.

Sorry for the ignorance but should I have loaded the "theme.min.js" and "theme.min.js.map"?

On the other hand, it is necessary to place the documentation in Chinese.

@HEIGE-PCloud
Copy link
Owner

Yes, you should commit theme.min.js and theme.min.js.map.

I will update the related Chinese documentation.

Thanks!

@vercel
Copy link

vercel bot commented Oct 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pcloud/do-it/Grt5acVvDfy5iLpFhpsjRb5CUijS
✅ Preview: https://do-it-git-fork-eyllanesc-dev-giscus-pcloud.vercel.app

@HEIGE-PCloud HEIGE-PCloud merged commit 5713dad into HEIGE-PCloud:main Oct 15, 2021
@eyllanesc eyllanesc deleted the dev/giscus branch October 15, 2021 11:38
@HEIGE-PCloud HEIGE-PCloud added new feature New feature and removed enhancement Enhance existing features labels Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add giscus comment system
2 participants