Skip to content

Commit

Permalink
Adding "beta" banners to relevant error report sections (#2522)
Browse files Browse the repository at this point in the history
* Update views.py

* Update views.py

* Update SubmissionHistory.jsx

* Update SubmissionHistory.test.js

* Apply suggestions from code review

Co-authored-by: Miles Reiter <mreiter@goraft.tech>

* lint fixes

---------

Co-authored-by: Miles Reiter <mreiter@goraft.tech>
Co-authored-by: Alex P <63075587+ADPennington@users.noreply.github.com>
Co-authored-by: andrew-jameson <ajameson@teamraft.com>
  • Loading branch information
4 people authored Jun 2, 2023
1 parent 914ee3b commit 238e85e
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
6 changes: 6 additions & 0 deletions tdrs-backend/tdpservice/parsers/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ def _get_xls_serialized_file(self, data):
'row_number',
'column_number']

# write beta banner
worksheet.write(row, col,
"Error reporting in TDP is still in development." +
"We'll be in touch when it's ready to use!" +
"For now please refer to the reports you receive via email")
row, col = 2, 0
# write csv header
[worksheet.write(row, col, key) for col, key in enumerate(report_columns)]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const SectionSubmissionHistory = ({ section, label, files }) => {
<th>Submitted On</th>
<th>Submitted By</th>
<th>File Name</th>
<th>Error Reports</th>
<th>Error Reports (In development)</th>
</tr>
</thead>
<tbody>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,10 @@ describe('SubmissionHistory', () => {
expect(screen.queryByText('test5.txt')).not.toBeInTheDocument()
expect(screen.queryByText('test6.txt')).toBeInTheDocument()

expect(screen.queryByText('Error Reports')).toBeInTheDocument()
expect(
screen.queryByText('Error Reports (In development)')
).toBeInTheDocument()

expect(screen.queryByText('Currently Unavailable')).toBeInTheDocument()
})

Expand Down

0 comments on commit 238e85e

Please sign in to comment.