-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2598] staging deployment failure issue #468
Conversation
Note: maximum configurable healthcheck timeout "-t" |
else | ||
cf push "$CGAPPNAME_BACKEND" --no-route -f manifest.buildpack.yml | ||
cf push "$CGAPPNAME_BACKEND" --no-route -f manifest.buildpack.yml -t 180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these might be insufficient for prod and we aren't running migrate automatically, perhaps we should ultimately remove the increase of timeout from default (60) to 180?
# python manage.py makemigrations | ||
# python manage.py migrate | ||
# python manage.py populate_stts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In testing steps of this PR, please provide the process we discussed during dev sync and/or ping me with relevant draft so we can be prepared for getting this fix to Alex.
@@ -0,0 +1,13 @@ | |||
import logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for a formal PR we should delete our debugger script since we determined this was not at cause.
- deploy-staging: | ||
requires: | ||
- deploy-infrastructure-staging | ||
filters: | ||
branches: | ||
only: | ||
- main | ||
- 2598-staging-deployment-failure-issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you intending to leave these here for qasp testing or should these be reverted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove some holdovers from our troubleshooting process and still need a process/steps for semi-manual migration as discussed in office hours.
Summary of Changes
Provide a brief summary of changes
Pull request closes #_
How to Test
List the steps to test the PR
These steps are generic, please adjust as necessary.
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):