Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated ticket #164

Closed
widal001 opened this issue Jul 7, 2023 · 0 comments
Closed

Deprecated ticket #164

widal001 opened this issue Jul 7, 2023 · 0 comments
Assignees

Comments

@widal001
Copy link
Collaborator

widal001 commented Jul 7, 2023

Description

@widal001 widal001 changed the title Milestone: Draft plan a UX research study on NOFO writers and grantor process Draft plan a UX research study on NOFO writers and grantor process Jul 7, 2023
@widal001 widal001 mentioned this issue Jul 11, 2023
1 task
@widal001 widal001 added this to the Evaluation plan and tools established to organize learning milestone Jul 12, 2023
@widal001 widal001 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2023
@widal001 widal001 removed this from the 1.1 Evaluation plan and tools established to organize learning milestone Jul 26, 2023
@widal001 widal001 changed the title Draft plan a UX research study on NOFO writers and grantor process Deprecated ticket Oct 3, 2023
acouch pushed a commit that referenced this issue Sep 18, 2024
…vapbc#195)

Fixes #164

Adds support to our search query builder layer to handle building
queries for filtering on ints and dates between specific date ranges.

Added ints and dates in the same ticket as the queries are essentially
the same, just ints vs dates. While it throws an exception if both start
and end values are None, I think the API request schema should also do
that so that the error is more relevant/accurate to the API, but I can
add that later (likely a lot more niche edge cases to handle for
requests).

Nothing too exciting with these queries, they work as expected and are
just simple ranges.

The test dataset is roughly accurate (turns out books didn't always have
exact release dates until the last ~20 years).

I also have tested these queries manually with the opportunity endpoints
fields, the following two queries would work (can be tested locally at
http://localhost:5601/app/dev_tools#/console ):
```
GET opportunity-index-alias/_search
{
  "size": 5,
  "query": {
    "bool": {
      "filter": [
          {
            "range": {
              "summary.post_date": {
                "gte": "2020-01-01",
                "lte": "2025-01-01"
              }
            }
          }
        ]
    }
  }
}

GET opportunity-index-alias/_search
{
  "size": 12,
  "query": {
    "bool": {
      "filter": [
          {
            "range": {
              "summary.award_floor": {
                "gte": 1234,
                "lte": 100000
              }
            }
          }
        ]
    }
  }
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants