-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 1258] Add local libs and fix a11y issues #1346
Conversation
aaad91f
to
e7d383e
Compare
app.config["SWAGGER_UI_BUNDLE_JS"] = "/static/swagger-ui-bundle.js" | ||
app.config["SWAGGER_UI_STANDALONE_PRESET_JS"] = "/static/swagger-ui-standalone-preset.js" | ||
# Removing because the server dropdown has accessibility issues. | ||
app.config["SERVERS"] = "." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this break the ability to use OpenAPI? The server info is currently automatically set for us, but if we manually set it, that might break querying entirely through the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to review the API Flask code to make sure there aren't side effects for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not going to be in APIFlask, probably something in apispec. We probably can't tell if this will be an issue until it is in dev as the server logic is going to be a lot simpler locally
From the summary |
Summary
Fixes #1258
Time to review: 10 mins
Changes proposed
Note about files:
Three files were moved to the API from the following sources:
The first two are unchanged. The css file had the following added in order to fix the contrast ratio:
This is a temporary solution as we will move the API docs before the Search UI is public.
Context for reviewers
None of the OpenAPI doc generators seem to be 508 compliant out of the box 😢
Additional information
Before:
After: